Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move version dependent functions to a separate file #43

Closed
Fubinator opened this issue Oct 9, 2020 · 2 comments · Fixed by #61 or pranshumaheshwari/cvss.js#2
Closed

Move version dependent functions to a separate file #43

Fubinator opened this issue Oct 9, 2020 · 2 comments · Fixed by #61 or pranshumaheshwari/cvss.js#2
Assignees
@pranshumaheshwari
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Fubinator
Copy link
Member

Fubinator commented Oct 9, 2020 •
edited
Loading

The cvss.js file is getting quite big. To implement #26 we should make sure we won't run into problems with different versions.

Since CVSS version 3.0 and 3.1 are very similar in terms of metrics and differ for the most part only in the calculations, all functions for calculating the scores should be in a separate file.

This should increase our ability to run tests more specifically by a lot as well.
@Fubinator Fubinator added enhancement New feature or request good first issue Good for newcomers hacktoberfest labels Oct 9, 2020
@Fubinator Fubinator mentioned this issue Oct 13, 2020
Closed
@pranshumaheshwari
Copy link
Contributor

I can work on this

@Fubinator
Copy link
Member Author

Yes, go 4 it @pranshumaheshwari if you have any questions feel free to ask.

pranshumaheshwari added a commit to pranshumaheshwari/cvss.js that referenced this issue Oct 14, 2020
@pranshumaheshwari
Resolved turingsecure#43
e1f1d97
@pranshumaheshwari pranshumaheshwari mentioned this issue Oct 14, 2020
Merged
Fubinator added a commit that referenced this issue Oct 15, 2020
@Fubinator
Merge pull request #61 from pranshumaheshwari/main
1a48e83 
Resolved #43
@pranshumaheshwari pranshumaheshwari mentioned this issue Oct 17, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranshumaheshwari pranshumaheshwari

Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
2 participants
@Fubinator @pranshumaheshwari