Include previous error even if there's a timeout

tim-kos/node-retry#70

Signed-off-by: Olli Vanhoja <olli.vanhoja@gmail.com>

__tests__/test-retry-operation.js

@@ -242,3 +242,33 @@ test("testMaxRetryTime", () => {
     });
   });
 });
+
+test('testErrorsPreservedWhenMaxRetryTimeExceeded', () => {
+  const error = new Error('some error');
+  const maxRetryTime = 30;
+  const operation = retry.operation({
+      minTimeout: 1,
+      maxRetryTime: maxRetryTime
+  });
+
+  const longAsyncFunction = function (wait, callback){
+    setTimeout(callback, wait);
+  };
+
+  return new Promise((resolve, reject) => {
+    const startTime = new Date().getTime();
+    operation.attempt(function() {
+
+      const curTime = new Date().getTime();
+      longAsyncFunction(maxRetryTime - (curTime - startTime - 1), function(){
+        if (operation.retry(error)) {
+          reject(new Error('timeout should be occurred'));
+          return;
+        }
+
+        expect(operation.mainError()).toBe(error);
+        resolve();
+      });
+    });
+  });
+});

lib/retry_operation.js

@@ -46,7 +46,9 @@ RetryOperation.prototype.retry = function(err) {
   }
   const currentTime = new Date().getTime();
   if (err && currentTime - this._operationStart >= this._maxRetryTime) {
+    this._errors.push(err);
     this._errors.unshift(new Error("RetryOperation timeout occurred"));
+
     return false;
   }