Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reddit.NewScript uses an http.Client which doesn't specify a timeout #38

Closed
boreq opened this issue Aug 19, 2018 · 3 comments
Closed

reddit.NewScript uses an http.Client which doesn't specify a timeout #38

boreq opened this issue Aug 19, 2018 · 3 comments

Comments

@boreq
Copy link

boreq commented Aug 19, 2018

It is impossible to replace that client or alter it in any way as it is private.

@turnage
Copy link
Owner

turnage commented Aug 20, 2018

I see. Feel free to submit a pr for a default timeout here. The proper way to way to add this to the API, I'm not sure. Probably through this.

@Flexicon
Copy link

Flexicon commented Apr 5, 2020

Should probably be closed since you can pass an http.Client through config now.

@turnage
Copy link
Owner

turnage commented Apr 5, 2020

You’re right.

@turnage turnage closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants