Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Inversion Principle #23

Closed
robi-y opened this issue Jun 3, 2013 · 5 comments
Closed

Dependency Inversion Principle #23

robi-y opened this issue Jun 3, 2013 · 5 comments

Comments

@robi-y
Copy link

robi-y commented Jun 3, 2013

Hi,
Your code is not so DIP
I suggest extracting an interface for DataBase and depend on it
@Gissues:{"order":50,"status":"done"}

@turner11
Copy link
Owner

turner11 commented Jun 3, 2013

Thanks

On Mon, Jun 3, 2013 at 8:54 PM, robi-y notifications@github.com wrote:

Hi,
Your code is not so DIP
I suggest extracting an interface for DataBase and depend on it


Reply to this email directly or view it on GitHubhttps://github.com//issues/23
.

@ghost ghost assigned shimshof Jun 3, 2013
@robi-y
Copy link
Author

robi-y commented Jun 3, 2013

We will leave that to iteration 4

@robi-y
Copy link
Author

robi-y commented Jun 3, 2013

Just note that in order to complete the task, you need to identify a needed change, e.g. work against a NoSql database.

@turner11 turner11 closed this as completed Jun 9, 2013
@ghost ghost assigned turner11 Jun 23, 2013
@turner11
Copy link
Owner

This issue was handled at commit done by Avi at 23/6/2013
Details are available here

@turner11
Copy link
Owner

As part of this re factoring, we have extracted an Interface from our data base class.
this correspond to the DIP design pattern and will allow to replace in the future the underlying layer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants