Fix inability to replace existing file on Windows #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjreed-wbd
requested review from
abarfoot,
davidhammturner,
jhodnett2 and
jritsema
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.renamefails on Windows if the target filename exists.os.replaceworks in that case (as long as the file is not in use), but that only exists in Python 3.3+. This change maintains compatibility with older versions of Python.The strategy is this: try the rename; if it fails with a
FileExistsError, then ifos.replaceis available, retry the operation with it; otherwise we accept the risk of the race condition by simply deleting the file and then trying therenameagain.To maximize the utility of this change, the Dockerfile has also been updated to build a container based on Python 3.6 instead of 2.7.