Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plagiarism_turnitin: Migrate Event 1 API to Event 2 #186

Closed
wants to merge 1 commit into from

Conversation

tlock
Copy link

@tlock tlock commented Nov 10, 2016

  • Updated events to use the new API
  • Remove all associated legacy events

 - Updated events to use the new API
 - Remove all associated legacy events
@roperto
Copy link
Contributor

roperto commented Nov 22, 2016

👍 Hi Tim, thanks for the migration, I am cherry-picking this until it arrives in master :-)

@roperto
Copy link
Contributor

roperto commented Jan 18, 2017

Just a late feedback, but some changes in the lib.php had a few problems here. Some of the event data parameters differ from the original one, I did not investigate further but it could be something related to:

https://github.com/turnitin/moodle-plagiarism_turnitin/pull/186/files#diff-828043dc9f8d10ccd58ff8b96297794fR2050

I think turnitin has several changes in their develop branch including database migrations, so for now we are still using event 1 API and waiting until they release it stable.

Cheers,
Daniel

@tlock
Copy link
Author

tlock commented Jan 18, 2017

Unfortunately, this hasn't solved all the issues so we'll leave it till we see what Tii do with the deprecated issues.

@dwinn
Copy link
Contributor

dwinn commented Jan 26, 2017

Hi @tlock ,

We have just released v2015012501, which contains our Event 2 API changes. Thanks for your input on the issue.

@dwinn dwinn closed this Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants