Some refactoring of gh_releases #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed usage, but other tweaks too.
OnGle
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Sorry I completely missed this, absolutely my fault for being slack with my notifications.
Yeah I don't have any issues with this explicitly, it makes sense to me to support this. As you note occasionally it can lead to unexpected results or errors with multi-page results and the query limit gets hit, perhaps long-term that could be addressed by somehow triggering a hard build failure if it does happen?
|
Thanks man. I'll merge this now then, but I like your idea of an error if the query limit gets hit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily the changes are to support unauthenticated usage. But some other tweaks too.
Note: under some circumstances (e.g. multipage results) unathenticated usage may lead to errors and/or unreliable results. So is generally not recommended in production...
FWIW the core of this has been sitting in my local dev common for some time. This is just a commit of what I've been using locally for a while, with a few more tweaks...