Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed order of SSLCert Generation #34

Closed
wants to merge 1 commit into from
Closed

Changed order of SSLCert Generation #34

wants to merge 1 commit into from

Conversation

OnGle
Copy link
Member

@OnGle OnGle commented Jun 18, 2015

Changed the order of ssl cert generation as to
stop programs that set hostname after sslcert regened
from encountering issues.

changed the order of ssl cert generation as to
stop programs that set hostname after sslcert regened
from encountering issues.
@alonswartz
Copy link
Member

This change requires updating the BLACKLIST in [1]. Though, the appliances which require the hostname (eg. magento) might fail when re-running [1] if it is skipped, and the hostname is changed.

If the hostname is the issue, maybe we should move the hostname inithook before the ssl-certs?

Another alternative might be to update the affected appliances to handle the error, and do the right thing (ie. re-run the ssl-cert inithook)?

I'm open to ideas. We just need to make sure the solution is idempotent, and will do the right thing in different scenarios (if a service is using the cert, we might need to restart it. if the user setup a signed-cert, we don't want to replace it with a self-signed cert, ...)

[1] https://github.com/turnkeylinux/inithooks/blob/master/turnkey-init

@alonswartz
Copy link
Member

@JedMeister any update on this per our phone discussion?

@JedMeister
Copy link
Member

After testing and testing and testing some more I have been unable to reproduce this issue. As I said over on turnkeylinux/tracker#400 I'm not sure what's going on... But it works now so we can close this...

@alonswartz alonswartz closed this Jul 31, 2015
JedMeister added a commit that referenced this pull request Mar 6, 2018
JedMeister pushed a commit to JedMeister/common that referenced this pull request Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants