Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Rails logs to proper place #6

Merged
merged 1 commit into from
Mar 2, 2015
Merged

move Rails logs to proper place #6

merged 1 commit into from
Mar 2, 2015

Conversation

wvengen
Copy link
Contributor

@wvengen wvengen commented Jun 26, 2014

fix for something that came up in turnkeylinux/tracker#216

@wvengen
Copy link
Contributor Author

wvengen commented Jun 26, 2014

Haven't tested this as thoroughly as I would have liked, but it should be fine.

@wvengen
Copy link
Contributor Author

wvengen commented Jun 27, 2014

It works, but I log permissions aren't always perfect - turnkeylinux/tracker#235.

@lirazsiri
Copy link
Member

It's usually not ideal for a webapp to have access to its own logs because if a security breach allows the attacker to gain www-data privileges he can then alter them. If we use syslog then the attacker needs to escalate to root privileges.

OTOH, the right configuration is rarely perfect, it just makes the best trade-offs for the usage scenarios we have in mind. It looks like it is possible to configuration Rails to use syslog but if I'm not mistaken this has to be done at the application (rather than the system level) level, so perhaps it isn't a good idea to rely on that.

@wvengen
Copy link
Contributor Author

wvengen commented Jun 27, 2014

Good point! Could require Rails appliance developers to use syslog? It's quite straightforward.

@lirazsiri
Copy link
Member

I wouldn't force anyone to make a change to their app or to even
understand what syslog is to get it to work on TurnKey, but... I think
it would be a good idea to provide instructions/documentation so that
people who want to do the right thing have an easier time of it.

On 27/06/14 12:24, wvengen wrote:

Good point! Could require Rails appliance developers to use syslog? It's quite straightforward.


Reply to this email directly or view it on GitHub:
#6 (comment)

@wvengen
Copy link
Contributor Author

wvengen commented Jun 27, 2014

I like your approach.

@wvengen
Copy link
Contributor Author

wvengen commented Jul 12, 2014

Is there anything holding back this pull request? I'd be happy to add a line to the page about Rails on logging when merged (though I can't seem to find one right now).

lirazsiri added a commit that referenced this pull request Mar 2, 2015
move Rails logs to proper place
@lirazsiri lirazsiri merged commit 60b2d8b into turnkeylinux:master Mar 2, 2015
@lirazsiri
Copy link
Member

Merged this finally, sorry for letting this slip through the cracks.

@wvengen wvengen deleted the feature-rails_logs branch May 15, 2015 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants