Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 port of tklamq #1

Merged
merged 11 commits into from Feb 16, 2022
Merged

Conversation

JedMeister
Copy link
Member

Python3 port of tklamq for v17.x

@OnGle @qq7

Copy link
Member

@OnGle OnGle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good although I'd like clarification on why stdin usage is no longer supported.

tklamq_lib/amqp.py Show resolved Hide resolved
fatal('TKLAMQ_SECRET not specified, cannot encrypt')

if args.input:
#if args.input == '-':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression, no longer handles stdin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it's a known regression. I did try briefly to get it working, but couldn't get it to work as I thought it should. AFAIK, that functionality isn't strictly required currently, so it shouldn't be a big deal for now. Having said that, I will open an issue.

@JedMeister
Copy link
Member Author

Argh! I forgot to push my most recent changes before I merged. It's not ideal, but I just cherry picked it and merged it in on top. FYI, the commit I added is: ce0db6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants