-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the PostBuild process with an embedded resource solution #30
Comments
I've taken a stab at this by embedding them.. sorry I haven't had a change to submit back. Will find time in the next month to clean up and submit a pull request: https://github.com/colinbowern/i18n/tree/master/src/i18n.PostBuild |
Thanks. I'll see what I can use from that---though I suspect I'll want to On Tue, Jan 29, 2013 at 12:10 PM, Colin Bowern notifications@github.comwrote:
Daniel Crenna |
@colinbowern I took a quick look and you have some other really nice enhancements here, so I think I'll want to bring them in. I'll let you know if I end up bringing them in before you do. |
Also, why does PostBuildTask need to be inside i18n? Shouldn't it be in the i18n. PostBuild project? That class doesn't have any behavior in there that is not using msmerge and xgettext (I mean, besides going through the cs and cshtml files), hence I don't see it as an extension point or something that can be reused in another context besides an executable. |
True, and fair point. I was just thinking about the possibility of a On Tue, Jan 29, 2013 at 1:49 PM, Raul Vejar notifications@github.comwrote:
|
I agree that anything that can be done to simplify managing the synchronization between the template and the application is a positive thing. But given that you don't want that slowing application restart and that with any change you would have to wait until the new strings have been translated in the PO files anyways, it really feels as an action that should be done offline as part of the application management process and not necesarily as part of the application building or running. |
+1 @raulvejarI Sometimes the Hosting is restrictive of starting a new process from inside a website(for example Azure Websites) and building the .PO files in App_Start could pose a problem. This is more administrative task and should be handled that way. |
Okay, we'll do it that way. I've always had a bias for dynamic processes So we'll do it your way and perhaps I'll just reference a hook for my own On Wed, Jan 30, 2013 at 4:04 AM, Apostol Apostolov <notifications@github.com
|
I believe issue #58 addition to v2 branch addresses this. |
Dealing with xgettext location with PostBuild is a big impediment to library adoption and ease of use. Let's make this fully automatic.
The text was updated successfully, but these errors were encountered: