Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http client execute multiple server responses error #60

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: http client execute multiple server responses error #60

merged 1 commit into from
Nov 24, 2023

Conversation

FeBrandao
Copy link
Contributor

http client execute function is returning two responses: results AND close stream. (raw_batch already had this change, both calling the same underlying method).

this fixes the response size verification.

psarna
psarna approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@psarna psarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for solving the issue! It used to work because one-shot request didn't come with Close before 0.33.1, which was a bug on its own

@psarna psarna merged commit 85522e7 into tursodatabase:main Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psarna psarna psarna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FeBrandao @psarna