Add type exports #69
Closed
Add type exports #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penberg
requested changes
Dec 20, 2023
|
Hi @penberg, I fixed some of the sync types to be in line with the actual js code and added async types. |
penberg
reviewed
Feb 27, 2024
| @@ -14,7 +14,6 @@ | |||
|
|
|||
| // FIXME: Is this `any` really necessary? | |||
| type VariableArgFunction = (...params: any[]) => unknown; | |||
| type ArgumentTypes<F extends VariableArgFunction> = F extends (...args: infer A) => unknown ? A : never; | |||
There was a problem hiding this comment.
Is it necessary to remove these from index.d.ts? I know we don't implement them right now, but I would like to keep them around because we are planning to implement all of them for compatibility.
There was a problem hiding this comment.
Well, I removed the type as it is the same as the built-in Parameters type. Do you want me to re-add it?
|
+1, was about to create a PR for this as well |
|
Fixed by f7d550f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this typescript complained at me