Skip to content

Commit

Permalink
feat(print-statements): intercept explain query plan statements
Browse files Browse the repository at this point in the history
  • Loading branch information
douglasmdev committed Aug 14, 2023
1 parent 5cc9ad0 commit 63b2ca9
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 1 deletion.
8 changes: 7 additions & 1 deletion internal/db/output.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ type TablePrinter struct {
func (t TablePrinter) print(statementResult StatementResult, outF io.Writer) error {
data := [][]string{}
table := createTable(outF)
if !t.withoutHeader {
showHeader := !IsResultComingFromExplainQueryPlan(statementResult) && !t.withoutHeader
if showHeader {
table.SetHeader(statementResult.ColumnNames)
}

Expand Down Expand Up @@ -100,6 +101,11 @@ func appendData(statementResult StatementResult, data [][]string, mode FormatTyp
}
data = append(data, formattedRow)
}

if IsResultComingFromExplainQueryPlan(statementResult) {
data = [][]string{{"Tree goes here!"}}
}

return data, nil
}

Expand Down
29 changes: 29 additions & 0 deletions internal/db/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"net/url"
"strings"
"unicode"

"golang.org/x/exp/slices"
)

func IsUrl(uri string) bool {
Expand Down Expand Up @@ -45,3 +47,30 @@ func NeedsEscaping(name string) bool {
}
return false
}

var explainQueryPlanStatement = "EXPLAIN QUERY PLAN"
var explainQueryPlanColumnNames = []string{"id", "parent", "notused", "detail"}

func queryContainsExplainQueryPlanStatement(query string) bool {
return strings.Contains(query, explainQueryPlanStatement)
}

func columnNamesMatchExplainQueryPlan(colNames []string) bool {
if len(colNames) != len(explainQueryPlanColumnNames) {
return false
}
for _, colName := range explainQueryPlanColumnNames {
if !slices.Contains(colNames, colName) {
return false
}
}
return true
}

// "query" can be a string containing multiple queries separated by ";" or a single query
func IsResultComingFromExplainQueryPlan(statementResult StatementResult) bool {
query := statementResult.Query
columnNames := statementResult.ColumnNames
return queryContainsExplainQueryPlanStatement(query) &&
columnNamesMatchExplainQueryPlan(columnNames)
}
13 changes: 13 additions & 0 deletions test/db_root_command_shell_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,19 @@ func (s *DBRootCommandShellSuite) Test_GivenATableNameWithSpecialCharacters_When
s.tc.AssertSqlEquals(outS, expected)
}

func (s *DBRootCommandShellSuite) Test_GivenATableNameWithTheSameSignatureAsExpainQueryPlan_WhenChainingItWithExplainQueryPlan_ExpectCorrectData() {
_, _, err := s.tc.Execute("CREATE TABLE fake_explain (ID INTEGER PRIMARY KEY, PARENT INTEGER, NOTUSED INTEGER, DETAIL TEXT)")
s.tc.Assert(err, qt.IsNil)

outS, errS, err := s.tc.ExecuteShell([]string{"SELECT * FROM fake_explain; EXPLAIN QUERY PLAN SELECT 1;"})
s.tc.Assert(err, qt.IsNil)
s.tc.Assert(errS, qt.Equals, "")

expected := "id parent notused detail \ntree goes here!"

s.tc.AssertSqlEquals(outS, expected)
}

func (s *DBRootCommandShellSuite) Test_GivenATableWithRecordsWithSingleQuote_WhenCalllSelectAllFromTable_ExpectSingleQuoteScape() {
s.tc.CreateEmptySimpleTable("t")
_, errS, err := s.tc.Execute("INSERT INTO t VALUES (0, \"x'x\", 0)")
Expand Down

0 comments on commit 63b2ca9

Please sign in to comment.