Use the namespace resolver to extract namespace #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinassh
force-pushed
the
ss-namespace
branch
2 times, most recently
from
1a1b552
to
7ebe45b
Compare
avinassh
requested review from
LucioFranco and
MarinPostma
and removed request for
LucioFranco
MarinPostma
reviewed
Jun 11, 2024
MarinPostma
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage server requires namespace UUID to operate. In the
WALManagerwe do not have access to the namespace, so this patch extracts the namespace from thedb_pathThe large diff is due to I moved
NamespaceNamefromlibsql-waltolibsql-sysso thatlibsql-storagealso can use it. Or else I could copy the resolver method https://github.com/tursodatabase/libsql/blob/7ebe45b52/libsql-server/src/lib.rs#L672-L684 insidelibsql-storageand use that.