Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v0.15.1 of cr-sqlite #434

Closed
wants to merge 5 commits into from

Conversation

tantaman
Copy link
Contributor

@tantaman tantaman commented Sep 29, 2023

This syncs the v0.15.1 release of cr-sqlite to libsql.

Todo:

Other / outside of this PR:

  • Re-enable this extension for Turso.
    • Note: if you auto-init this extension on connection create it will increase the time to create a new SQLite connection. Are Turso connections cached? Should we lazily init the extension? I've not measured this number but loading the extension involves preparing some statements which isn't cheap in SQLite.
  • Complete cr-sqlite x Turso example -- Turso example vlcn-io/cr-sqlite#376

@tantaman tantaman changed the title Update v0.15.1 of cr-sqlite Update to v0.15.1 of cr-sqlite Sep 29, 2023
tantaman added a commit to vlcn-io/libsql that referenced this pull request Sep 29, 2023
libsql_close_hook was added here in tursodatabase#219 but it is not available to loadable extensions.

Following the same pattern was was done for `wal_methods_unregister` (tursodatabase@47e59b7) to expose this to loadable extensions.

- Will be used in tursodatabase#434 to do cleanup of cr-sqlite
tantaman added a commit to vlcn-io/libsql that referenced this pull request Sep 29, 2023
libsql_close_hook was added here in tursodatabase#219 but it is not available to loadable extensions.

Following the same pattern was was done for `wal_methods_unregister` (tursodatabase@47e59b7) to expose this to loadable extensions.

- Will be used in tursodatabase#434 to do cleanup of cr-sqlite
@tantaman tantaman marked this pull request as ready for review October 10, 2023 13:53
@tantaman tantaman marked this pull request as draft October 10, 2023 13:54
@tantaman tantaman marked this pull request as ready for review October 10, 2023 13:55
@penberg
Copy link
Collaborator

penberg commented Oct 11, 2023

@tantaman Looks good! There are some conflicts that prevent merging, though.

@tantaman
Copy link
Contributor Author

@penberg - Once this is in, how can I go about getting it enabled on my turso instance? Or is it pretty simple to stand up sqld as if it were Turso on my own box?

@tantaman
Copy link
Contributor Author

Conflicts resolved.

@psarna psarna enabled auto-merge October 17, 2023 11:41
@psarna
Copy link
Collaborator

psarna commented Oct 17, 2023

ah snap, some more conflicts appeared; I'll try to go over them manually if trivial

@tantaman
Copy link
Contributor Author

tantaman commented Oct 17, 2023

I can rebase again and see what's up. Weird that ext/crr files are conflicting since those shouldn't have changed in main 🤔

psarna pushed a commit to psarna/libsql that referenced this pull request Oct 18, 2023
@psarna
Copy link
Collaborator

psarna commented Oct 18, 2023

I ended up rebasing manually; we restructured the repo lately and moved the root directory to libsql-sqlite3, hence the huge conflicts

@tantaman
Copy link
Contributor Author

tantaman commented Oct 20, 2023

closing in favor of: #488

which uses the new directory layout.

ah, you already did it here: #472

@tantaman tantaman closed this Oct 20, 2023
auto-merge was automatically disabled October 20, 2023 17:17

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants