libsql: fix deferred txn with embedded replicas #559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where embedded replica based connections would have issues dispatching executes on deferred statements. This is due to sqld using `sqlite3_txn_state` to return the connection's state. While this works for other transactions, in a deferred transaction the connection does not change its state to be in a transaction. This is due to the nature of a deferred transaction. The problem is that the connection does set `is_autocommit` to `false`. This means that sqld is returning that it is not in a txn state which is used by clients to set its `is_autocommit` state. For now the work around is to track when the client is in a `DEFERRED` transaction and to handle remote state transition's in such a way that it ignores the value from the server if it is currently in the deferred state.
LucioFranco
force-pushed
the
lucio/fix-deferred-txn
branch
from
007384b
to
d1a75ba
Compare
psarna
requested changes
Nov 2, 2023
There was a problem hiding this comment.
One change is needed in the state transition code, but I have a more fundamental question.
Why would we use sqlite3_txn_state to determine autocommit mode in sqld, if we have sqlite3_get_autocommit? https://www.sqlite.org/c3ref/get_autocommit.html
psarna
approved these changes
Nov 2, 2023
|
Fixed via #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where embedded replica based connections would have issues dispatching executes on deferred statements. This is due to sqld using
sqlite3_txn_stateto return the connection's state. While this works for other transactions, in a deferred transaction the connection does not change its state to be in a transaction. This is due to the nature of a deferred transaction. The problem is that the connection does setis_autocommittofalse. This means that sqld is returning that it is not in a txn state which is used by clients to set itsis_autocommitstate. For now the work around is to track when the client is in aDEFERREDtransaction and to handle remote state transition's in such a way that it ignores the value from the server if it is currently in the deferred state.