Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LogService as express log handler #212

Merged

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented May 10, 2022

This makes it as configurable (and as mute-able) as the rest of bot-sdk logs,
instead of always landing on stdout.

Two regressions/changes that this currently brings:

  1. Since LogService prefixes every logline with the name of the module that spat it out, this changes the access.log format by prefixing it all with Appservice. Not sure if this is a huge deal since the logs are far too noisy right now to treat them as structured & predictable access logs
  2. This adds an extra newline at the end due to both morgan and LogService adding their own

This makes it as configurable (and as mute-able) as the rest of bot-sdk logs,
instead of always landing on stdout.
@turt2live turt2live merged commit 6851613 into turt2live:master May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants