Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty bodies to /join, /leave #249

Merged
merged 2 commits into from Jul 31, 2022
Merged

Add empty bodies to /join, /leave #249

merged 2 commits into from Jul 31, 2022

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jul 26, 2022 •
edited

Fixes #248

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

Signed off by: Will Hunt me@half-shot.uk

@Half-Shot Half-Shot changed the title Hs/empty bodies Add empty bodies to /join, /leave Jul 26, 2022
turt2live
turt2live requested changes Jul 26, 2022
View reviewed changes
Copy link
Owner

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked on investigation from the spec side

@turt2live turt2live merged commit edde101 into turt2live:main Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/join, /leave and other endpoints with empty bodies should send empty-object, not empty-string
2 participants
@Half-Shot @turt2live