Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MatrixError a non-default export #257

Merged
merged 1 commit into from Sep 21, 2022

Conversation

Half-Shot
Copy link
Contributor

I made the mistake of making this class a default, which means that when it was exported it would not be a named class and therefore be unimportable. We've worked around this in some projects by directly depending on MatrixError.ts file, but that's a sucky way to do it.

This PR changes the class to be a regular exported class, and changes all internal references to match. This will break projects that depended on the class being a default, but arguably that's not supported behavior. It's also trivial to go and fix your imports on the next update.

Checklist

  • [N/A - types change] Tests written for all new code ()
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

Signed-off-by: Will Hunt signoff@half-shot.uk

@turt2live turt2live merged commit 836c2da into turt2live:main Sep 21, 2022
@turt2live turt2live changed the title Remove default from MatrixError Make MatrixError a non-default export Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants