Query & claim needed keys before encrypting #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the bot has all keys needed for sharing a room key with recipients before encryping an event in that room. Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
turt2live
reviewed
Nov 18, 2022
src/e2ee/RustEngine.ts
Outdated
| @@ -106,6 +107,14 @@ export class RustEngine { | |||
| settings.rotationPeriod = BigInt(encEv.rotationPeriodMs); | |||
| settings.rotationPeriodMessages = BigInt(encEv.rotationPeriodMessages); | |||
|
|
|||
| await this.run(RequestType.KeysQuery); | |||
There was a problem hiding this comment.
This doesn't appear to cause a query request to happen?
There was a problem hiding this comment.
It does, because by the time this is hit, the CryptoClient has updated the list of tracked users in the room, which queues outgoing key query requests in the crypto state machine.
Without this line, the first message a bot sends in an encrypted room with a user it hasn't seen before will be unencryptable by that user.
Otherwise, the SDK calls RustEngine.run (and processes all outgoing requests, including key queries) after having already sent its first (encrypted) message, meaning it won't have the device key of new users & can't send them the to-device message containing the room key.
AndrewFerr
added a commit
to element-hq/matrix-bot-sdk
that referenced
this pull request
Dec 8, 2022
Ensure that the bot has all keys needed for sharing a room key with recipients before encryping an event in that room. Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
AndrewFerr
added a commit
to element-hq/matrix-bot-sdk
that referenced
this pull request
Dec 8, 2022
Ensure that the bot has all keys needed for sharing a room key with recipients before encryping an event in that room. Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
AndrewFerr
added a commit
to element-hq/matrix-bot-sdk
that referenced
this pull request
Dec 9, 2022
Ensure that the bot has all keys needed for sharing a room key with recipients before encryping an event in that room. Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
AndrewFerr
added a commit
to element-hq/matrix-bot-sdk
that referenced
this pull request
Dec 9, 2022
Ensure that the bot has all keys needed for sharing a room key with recipients before encryping an event in that room. Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
AndrewFerr
added a commit
to element-hq/matrix-bot-sdk
that referenced
this pull request
Dec 9, 2022
Ensure that the bot has all keys needed for sharing a room key with recipients before encryping an event in that room. Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
turt2live
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the bot has all keys needed for sharing a room key with recipients before encryping an event in that room.
Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Checklist