Send to-device event list, not wrapper, to engine #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of matrix-org/matrix-rust-sdk@a443e7277, the JSON-encoded `toDeviceEvents` passed to OlmMachine.receiveSyncChanges must be the list of events themselves, instead of a wrapper object that contains the event list. Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of matrix-org/matrix-rust-sdk@a443e7277, the JSON-encoded
toDeviceEventspassed to OlmMachine.receiveSyncChanges must be the list of events themselves, instead of a wrapper object that contains the event list.Signed-off-by: Andrew Ferrazzutti andrewf@element.io
Checklist
This fixes the mysterious crypto error of
invalid type: map, expected a sequencethat started happening after updating tobeta.3of the Rust SDK.The reason behind the crash is that
CryptoClient.updateSyncDatawas sending a JSON-encoded wrapper object around a list of to-devices message, which has the form{"events":[...]}. This used to be valid, but matrix-org/matrix-rust-sdk@a443e7277 changed the expected format to just the event list, instead of an object containing the list. An example of the new format in use can be found intests/machine.test.js.This fixes crashes for both bots & appservices, as even the latter calls
CryptoClient.updateSyncDatadespite "sync-ish" things typically being used only by bots.Note that bots may still crash in
CryptoClient.updateSyncDatawithout #272.