Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add external_ids typings to SynapseUser #296

Merged
merged 4 commits into from May 13, 2023
Merged

Add external_ids typings to SynapseUser #296

merged 4 commits into from May 13, 2023

Conversation

tadzik
Copy link
Contributor

@tadzik tadzik commented Jan 23, 2023 •
edited

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

@tadzik
Add external_ids typings to SynapseUser
6693f23 
Signed-off-by: Tadeusz Sośnierz <tadeusz@sosnierz.com>
@turt2live
Copy link
Owner

This appears to have CI failures, ftr.

@tadzik
Copy link
Contributor Author

tadzik commented Apr 13, 2023

This appears to have CI failures, ftr.

Thanks, should be good now.

turt2live
turt2live approved these changes May 13, 2023
View reviewed changes
Copy link
Owner

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live turt2live enabled auto-merge (squash) May 13, 2023 02:04
@turt2live turt2live merged commit b329067 into turt2live:main May 13, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tadzik @turt2live