Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a sync after creating a new filter #297

Merged
merged 2 commits into from Mar 24, 2023

Conversation

dhenneke
Copy link
Contributor

@dhenneke dhenneke commented Feb 13, 2023

When we provide a filter to the sync endpoint, the sync is never started if the filter needs to be created. If the filter already exists, everything starts correctly. Looks like a past refactoring broke it.

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

Signed-off-by: Dominik Henneke <dominik.henneke@nordeck.net>
Copy link
Owner

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@turt2live
Copy link
Owner

I can't seem to update the base branch here, or tell the CI to run: please update the branch when you get a chance.

@dhenneke
Copy link
Contributor Author

Thanks for having a look. I updated the branch and hope you will be able to run the workflows now.

@turt2live turt2live merged commit 7f09008 into turt2live:main Mar 24, 2023
7 checks passed
@dhenneke dhenneke deleted the nic/feat/fix-sync-with-filter branch March 24, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants