Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage of the SQLite-based crypto store #315

Merged
merged 9 commits into from May 13, 2023
Merged

Allow usage of the SQLite-based crypto store #315

merged 9 commits into from May 13, 2023

Conversation

AndrewFerr
Copy link
Contributor

@AndrewFerr AndrewFerr commented Apr 17, 2023 •
edited

Checklist

  • Tests written for all new code
  • Linter has been satisfied
  • Sign-off given on the changes (see CONTRIBUTING.md)

@AndrewFerr
Allow usage of the SQLite-based crypto store
3bd23c4 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Add types for lowdb
c73cacf 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Update tests
bce5d60 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Update examples
00a0b27 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Fix lint rules for new the imports in examples
dc8202a 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Test the SQLite crypto store
4c07639 
Run all tests with both the Sled and SQLite store types

Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Fix lint rules
3f24fb5 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr
Add missing semicolon
a983376 
Signed-off-by: Andrew Ferrazzutti <andrewf@element.io>
@AndrewFerr AndrewFerr mentioned this pull request Apr 20, 2023
Merged
3 tasks
turt2live
turt2live approved these changes May 13, 2023
View reviewed changes
Copy link
Owner

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Technically this should be an all-new class, but given I was the one who named the RustSdkCryptoStore so poorly, this is fine :D

I've added some defaults to make it backwards compatible, but otherwise this looks good.

src/storage/RustSdkCryptoStorageProvider.ts Outdated Show resolved Hide resolved
src/storage/RustSdkCryptoStorageProvider.ts Outdated Show resolved Hide resolved
@turt2live turt2live merged commit 943cef4 into turt2live:main May 13, 2023
7 checks passed
@AndrewFerr AndrewFerr deleted the af/sql-crypto-store branch June 13, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndrewFerr @turt2live