This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
Use human readable names for chats that aren't named (eg. converted direct message rooms) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should fix the repo (I can now run `npx ng serve` without error) and should also works on Apple Silicon (`node-sass` has issues)
If only one member is found in a room, set the room name to `Unnamed ($MEMBERNAME)`. If more than one member is found the room name is left as null and the raw Matrix address is used (as previous behaviour). Lazy loading is used so member list is not necessarily exhaustive. The only situation I can imagine this failing is when only one other user has been messaging in a group chat for a long time. To guarantee all members are retrived a request to /members for a specified room would be required (not implemented). Closes turt2live#6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name room based on member, if only one member present
If only one member is found in a room, set the room name to
Unnamed ($MEMBERNAME).If more than one member is found the room name is left as null and the raw Matrix address is used (as previous behaviour).
Lazy loading is used so member list is not necessarily exhaustive. The only situation I can imagine this failing is when only one other user has been messaging in a group chat for a long time.
To guarantee all members are retrived a request to /members for a specified room would be required (not implemented).
First commit is content of my previous PR (#10), please merge that first.
Closes #6