Resolve #27. Enable compilation against 0.9.1 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated bindings to include all additions since 0.9.0.99:
* `rd_kafka_position` renamed to `rd_kafka_committed`
* Added bindings to new version of `rd_kafka_position`
* Added bindings to `rd_kafka_timestamp_type_t` and
`rd_kafka_message_timestamp`
* Reordered `InternalRdKafkaEnum.chs` in `haskakafka.cabal` to enable
`{#import ... }` of `rd_timestamp_type_t *` in `InternalRdKafka.chs`
|
After this get merged, can you make a release on hackage? @cosbynator , because the hackage version is a bit old and not buildable with lastest librdkafka 0.9.1. |
|
I have a "watermark" patch made against this PR... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated bindings to include all additions since 0.9.0.99:
rd_kafka_positionrenamed tord_kafka_committedrd_kafka_positionrd_kafka_timestamp_type_tandrd_kafka_message_timestampInternalRdKafkaEnum.chsinhaskakafka.cabalto enable{#import ... }ofrd_timestamp_type_t *inInternalRdKafka.chs