-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the onUploadUrlAvailable callback option #543
Conversation
👍 🥇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you very much already!
test/spec/test-common.js
Outdated
}) | ||
|
||
await options.onSuccess.toBeCalled | ||
expect(options.onUploadUrlAvailable).toHaveBeenCalled() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this assertion before await options.onSuccess.toBeCalled
so we know that the callback is invoked directly after the HEAD response? Or does this asynchronous behavior interfere with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Following this conversation #524, I would like to propose to make the
onUploadUrlAvailable
callback officially and publicly available as an option.