Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #652: retryDelays type missing null #655

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix for issue #652: retryDelays type missing null #655

merged 1 commit into from
Dec 5, 2023

Conversation

dmitriiprusakov
Copy link
Contributor

Issue: #652

Acconut
Acconut approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@Acconut Acconut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@Acconut Acconut linked an issue Dec 5, 2023 that may be closed by this pull request
RetryDelays: "Type 'null' is not assignable to type 'number[] | undefined'". But null is acceptable. #652
Closed
@Acconut Acconut merged commit 14e57fa into tus:main Dec 5, 2023
4 of 5 checks passed
@dmitriiprusakov
Copy link
Contributor Author

@Acconut , also approximately when will this be released?

@Acconut
Copy link
Member

Acconut commented Dec 7, 2023

It has already been released in v3.1.2

@dmitriiprusakov
Copy link
Contributor Author

@Acconut, thats great, thanks!
Maybe you also know when it will be updated as dependency in @uppy/tus?
Or I need to ask in uppy repo about this?

@Acconut
Copy link
Member

Acconut commented Dec 13, 2023

Please ask this question in the Uppy repository or in the community forum at https://community.transloadit.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Acconut Acconut Acconut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RetryDelays: "Type 'null' is not assignable to type 'number[] | undefined'". But null is acceptable.
2 participants
@dmitriiprusakov @Acconut