Actually test HEAD promise resolution

tus · Nov 27, 2015 · 2afecab · 2afecab
1 parent de290a1
commit 2afecab
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 8 deletions.
diff --git a/lib/handlers/HeadHandler.js b/lib/handlers/HeadHandler.js
@@ -22,7 +22,7 @@ class HeadHandler extends BaseHandler {
         }
 
         const file_name = match[1];
-        this.store.getOffset(file_name)
+        return this.store.getOffset(file_name)
             .then(stats => {
                 res.setHeader('Upload-Offset', stats.size);
                 res.end();

diff --git a/lib/stores/DataStore.js b/lib/stores/DataStore.js
@@ -70,7 +70,7 @@ class DataStore {
     getOffset(id) {
         return new Promise((resolve, reject) => {
             if (!id) {
-                return reject('No file rID');
+                return reject('No file ID');
             }
             resolve({ size: 0 });
         });

diff --git a/test/HeadHandler.js b/test/HeadHandler.js
@@ -34,18 +34,17 @@ describe('HeadHandler', () => {
     it('should 404 if no file ID ', (done) => {
         req.headers = {};
         req.url = `${path}/`;
-        handler.send(req, res);
-        // This isn't really testing the promise resolution?
+        handler.send(req, res)
         assert.equal(res.statusCode, 404)
         done();
     });
 
     it('should resolve a promise with the offset', (done) => {
         req.headers = {};
         req.url = `${path}/1234`;
-        handler.send(req, res);
-        // This isn't really testing the promise resolution?
-        assert.equal(res.statusCode, 200)
-        done();
+        handler.send(req, res).then(() => {
+            assert.equal(hasHeader(res, { 'Upload-Offset': 0 }), true);
+            assert.equal(res.statusCode, 200);
+        }).then(done);
     });
 });