Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isCompleted to Upload info class #459

Closed
Murderlon opened this issue Jul 19, 2023 · 5 comments
Closed

Add isCompleted to Upload info class #459

Murderlon opened this issue Jul 19, 2023 · 5 comments

Comments

@Murderlon
Copy link
Member

This could be useful for lifecycle rules in S3 to clean up incomplete parts and in general.

@Acconut
Copy link
Member

Acconut commented Jul 25, 2023

I am not sure if an entry inside the JSON content of the info object would help here (that's how I understand your proposal). AFAIK, S3 lifecycle rules are not able to access the content of files stored on S3 and can thus not filter out files that are missing the isCompleted property.

S3 tags might help here: https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html Each completed upload can get a isCompleted tag and then the lifecycle rules can filter out files that don't have this tag but are too old.

@fenos
Copy link
Collaborator

fenos commented Jul 26, 2023

Yes, this should be part of a tag in order for lifecycle rules to pick the right files

@mitjap
Copy link
Collaborator

mitjap commented Oct 23, 2023

You can set lifecycle rules for incomplete multipart uploads without the use of tags.

https://aws.amazon.com/blogs/aws-cloud-financial-management/discovering-and-deleting-incomplete-multipart-uploads-to-lower-amazon-s3-costs/

@fenos
Copy link
Collaborator

fenos commented Nov 14, 2023

@mitjap incompleteParts are uploaded as real objects in S3 not as parts, hence this was required. However, i think that using the expiration date is cleaner as implemented here #513

@Murderlon
Copy link
Member Author

Closed in #513

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants