-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTPS being overridden to HTTP #469
Comments
I think it works as expected currently? |
I also hit the error with the Location header switching to HTTP with the service behind an HTTPS Load Balancer. The initial create request will work over HTTPS but the upload fails as it relies on the value returned in the |
AFAIK when running behind a reverse-proxy, it's better to let the proxy add What do you think? |
Relative location works well and I can't think of a downside to using it. Am I missing one(or many 😅)? That said, respectForwardedHeaders is clearly there and documented for this purpose as you suggest. I just missed it. Easy to configure on Nginx and is included by default on GCP Load Balancers. https://cloud.google.com/load-balancing/docs/https#target-proxies Maybe a little more effort in k8s ingress-nginx. |
I meant more rather than introducing a new option, like So this issue can be closed then? I'm also okay with clarifying the docs if something is unclear. |
Works fine for me either way. Thanks |
I know this has been closed, Could you please explain how I could update the tus-node-server so it uses the current protocol and not just HTTP? many thanks |
See these previous comments: #469 (comment) and #469 (comment) |
@Murderlon - my issue #550 is marked as duplicate, but we used respectforwardheader option and issue still persist. |
@D2rTech what is the setup you are working with? If you are using https initially that means one or more reverse proxies/load balancers (as tus server does not support tls) If you check the headers sent between each layer you will likely find the issue. When the headers mentioned above are sent it should work. Log the headers received by tus-server |
Environment:
Server: Nodejs, Express
Everything works as expected over http. However over https, it rewrites the protocol to http:
See the image below. The request was made over https but Location headers is http. This creates the mixed content issue and access problems.
The text was updated successfully, but these errors were encountered: