Fix memory leaks on interrupted upload #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! i didn´t know |
|
oh god, this would explain those memory leaks I got in a project sometime ago :S |
Murderlon
approved these changes
Feb 28, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connection is closed by client (for example when pausing an upload), promise is never settled, which causes memory leak. This issue is present in FileStore and GCSDataStore (not sure about S3Store). In case of FileStore files might stay in write mode and locked.
When using
.pipe()not all events are connected, so I switched it to newstream.pipeline(source, destination, cb).This was inspired by #34.