-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2: Rework hooks system #516
Conversation
Have you considered only supporting go-plugins for hooks and implementing http, grpc and file hooks as plugin implementations? It would simplify the code you have to maintain in tusd. Granted, it would also introduce a slight performance hit. |
Yes, but it's a tradeoff. I doubt it would reduce code complexity as every hook implementation would need the code for the go-plugin setup. Furthermore, it would make tusd not a single, all-containing binary anymore as users need to ensure that the plugin files are present during runtime. |
This branch is used to develop the new hook system. The main concepts will stay the same (i.e. file, HTTP, gRPC hooks) but the exact interface has to change.
Goals:
TODO (will be addressed after merge):
pkg/