Sending a POST to a file uri should not create a new file

tusdotnet · Nov 11, 2023 · 331d707 · 331d707
1 parent 8ac0ebc
commit 331d707
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 2 deletions.
diff --git a/Source/tusdotnet.test/Tests/EndpointRoutingTests.cs b/Source/tusdotnet.test/Tests/EndpointRoutingTests.cs
@@ -11,10 +11,12 @@
 using NSubstitute;
 using Shouldly;
 using System;
+using System.Net;
 using System.Net.Http;
 using System.Threading.Tasks;
 using tusdotnet.Interfaces;
 using tusdotnet.Models;
+using tusdotnet.test.Extensions;
 using Xunit;
 
 namespace tusdotnet.test.Tests
@@ -60,6 +62,28 @@ public async Task The_Endpoint_Configuration_Factory_Is_Used()
             endpointFactoryUsed.ShouldBeTrue();
         }
 
+        [Fact]
+        public async Task Ignores_Request_If_Url_Does_Not_Match()
+        {
+            using var server = CreateTestServer(endpoints => endpoints.MapTus("/files", _ => Task.FromResult(CreateConfig())));
+
+            await SendAndAssert(server, "/files", HttpStatusCode.Created);
+
+            await SendAndAssert(server, "/otherfiles", HttpStatusCode.NotFound);
+
+            await SendAndAssert(server, "/files/testfile", HttpStatusCode.NotFound);
+
+            static async Task SendAndAssert(TestServer server, string path, HttpStatusCode expectedStatusCode)
+            {
+                var response = await server.CreateRequest(path)
+                    .AddTusResumableHeader()
+                    .AddHeader("Upload-Length", "100")
+                    .SendAsync("POST");
+
+                response.StatusCode.ShouldBe(expectedStatusCode);
+            }
+        }
+
         private static TestServer CreateTestServer(Action<IEndpointRouteBuilder> endpoints, Action<IServiceCollection> configureServices = null)
         {
             var builder = new WebHostBuilder()
@@ -83,7 +107,7 @@ private static DefaultTusConfiguration CreateConfig(Action onAuthorizeCalled = n
         {
             return new DefaultTusConfiguration
             {
-                Store = Substitute.For<ITusStore>(),
+                Store = Substitute.For<ITusStore, ITusCreationStore>(),
                 Events = new()
                 {
                     OnAuthorizeAsync = _ =>

diff --git a/Source/tusdotnet/Adapters/EndpointUrlHelper.cs b/Source/tusdotnet/Adapters/EndpointUrlHelper.cs
@@ -2,6 +2,8 @@
 
 namespace tusdotnet.Adapters
 {
+    // This class assumes that it's running for an endpoint and such we already know that
+    // the path pattern matches as the code would not run otherwise.
     internal class EndpointUrlHelper : IUrlHelper
     {
         public static EndpointUrlHelper Instance { get; } = new();
@@ -22,7 +24,7 @@ public bool UrlMatchesFileIdUrl(ContextAdapter context)
 
         public bool UrlMatchesUrlPath(ContextAdapter context)
         {
-            return true;
+            return !UrlMatchesFileIdUrl(context);
         }
     }
 }