Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceLink Path Bug #84

Closed
marlon-tucker opened this issue Feb 6, 2020 · 4 comments
Closed

SourceLink Path Bug #84

marlon-tucker opened this issue Feb 6, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@marlon-tucker
Copy link

Hello,

Using version 2.2.2

I'm trying to debug why a PATCH request isn't being handled by the tusdotnet middleware and have discovered an issue with the source link to the github project.

Visual studio is attempting to load the source from this url:

https://raw.githubusercontent.com/tusdotnet/tusdotnet/e139c0f4d4e53b8728065bd618a5b7f54e85d990/Tools/tusdotnet/ExternalMiddleware/Core/TusCoreMiddleware.cs

However this returns 404 not found. The correct url would be:

https://raw.githubusercontent.com/tusdotnet/tusdotnet/e139c0f4d4e53b8728065bd618a5b7f54e85d990/Source/tusdotnet/ExternalMiddleware/Core/TusCoreMiddleware.cs

I notice the tools folder contains the ps1 script which builds the nuget package. It seems that is interfering with the path somehow.

I'm not hugely familiar with how the source linking process works as I haven't personally published a nuget package so I'm not sure if this is a bug in this repo or a bug in the source link project.

Thanks

Marlon

@smatsson
Copy link
Collaborator

smatsson commented Feb 6, 2020

Interesting, thanks for reporting. Will have a look and fix it for the 2.3 release. Probably an issue with the build script.

@smatsson smatsson added the bug label Feb 6, 2020
@smatsson smatsson added this to the 2.3 milestone Feb 6, 2020
@smatsson smatsson self-assigned this Feb 6, 2020
@smatsson
Copy link
Collaborator

smatsson commented Feb 6, 2020

I have updated the symbol package on nuget but it will apparently take some time before it has been indexed:

The symbols for this package have not been indexed yet. They are not available for download from the NuGet.org symbol server. Symbols will be available for download after both validation and indexing are complete. Symbols validation and indexing may take up to an hour. Read more.

Once completed, you should be able to grab the new symbol package by deleting your local cache copy then restore nuget packages. Local cache is found in:

Windows: %userprofile%\.nuget\packages
Mac/Linux: ~/.nuget/packages

@marlon-tucker
Copy link
Author

Thank you, in the mean time I got around it by cloning the repo, going to the 2.2.2 tag and pointing VS at that source.

@smatsson
Copy link
Collaborator

smatsson commented Feb 12, 2020

Apparently nuget.org cannot validate the new symbol package and only gives me a vague error. I have contacted nuget support to see if they can help me out.

EDIT: Apparently an issue with nuget: NuGet/NuGetGallery#7844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants