Path one place setup #193
Merged
Path one place setup #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First Time runner might always run to exception since C:\tusfiles is not found or accessible. changing path also requires changing multiple hard-coded path. If it is acceptable, i made it one place only and in current path.
|
Hi, Thanks for your PR! This is a good catch for newcomers. Not 100% sure I like the use of CurrentDomain.SetData but it's probably good enough for now until we figure something "better". |
|
Thanks, I hope i learn "better" and be helpful. |
|
Sorry if I came across as smug. I was under a bit of time pressure. I like the concept of what you did here but not a fan of the magic string put into the app domain. A simple static property on the program class would probably have been easier to reason about. :) Anyhow, good catch on the getting started with tusdotnet part, so thanks you for that. 👍 |
|
No problem, appreciated. Thanks that would be way better. 😍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First Time runner might always run to exception since
C:\tusfilesis not found or accessible. changing path also requires changing multiple hard-coded path.If it is acceptable, i made it one place only and in current path.