Dev/205 new client disconnect guard #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatsson
force-pushed
the
dev/205-new-client-disconnect-guard
branch
2 times, most recently
from
9c46bfa
to
f239291
Compare
+ Code cleanup and xmldoc on ClientReadTimeout
smatsson
force-pushed
the
dev/205-new-client-disconnect-guard
branch
from
f239291
to
cbfddb6
Compare
This increases stability in cases where data is in transfer but has not yet reached the server when the client disconnects and reconnects. In earlier version this would cause the wrong offset to be retrieved. The client would continue from that offset causing an error when trying to patch the data once the lock had been released (offset mismatch). Response code for locked operations have been changed from 409 Conflict to 423 Locked to better conform to how clients and other servers are implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.