-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: better ARIA support and less click listeners #41
Comments
I'm going to add better aria support. Actually I'm new to a11y. The support of a11y will be gradually added. You advice is very useful. I'll keep the issue open. If anyone could help I'd very appreciate. PR welcomed! |
Any update on this ticket? I'm also thinking of implementing a11y and better keyboard support. It would be helpful if you mention which component you're working on so that we can start with a different component. |
Currently you can pick any component you want to implement. Just mark it here. If it's duplicate I'll let you know. |
I'll be happy to help too. I think we can use this as a starting point. https://www.w3.org/TR/wai-aria-practices-1.1/#aria_ex. We can put a list of TODOs like this:
Maybe we can create a board to have a better tracking? Anyway I'll start with the Alert component |
modal done, ref 5ab2182 |
Is this still active? |
Cards headers are lacking Aria roles |
This is still active. You can open an issue for specific component to let us know you need it so that we can add it early. |
What problem does the feature solve?
I find there're two issues on the doc website:
[role="button"]
, like dropdown menuitems, radio buttons and breadcrumbsdisabled
components still has click listeners but no[aria-disabled]
is added, like cascader menuitems and checkboxes<input>
is wrapped by<div>
s, and thediv.n-input
has a click listener but without[aria-hidden=true]
What does the proposed API look like?
I have an extension "Vimium C" to help users use keyboard to click page elements, and when it find links, it will pick those with
[role=button], [role=link]
and filter out those[aria-hidden], [aria-disabled], [aria-hidden=true], [aria-disabled=true]
. It also hooks the globaladdEventListener
function to learn what "plain" elements are clickable.When I tested Vimium C's
LinkHints.activate
(triggered byf
) on pages like https://www.naiveui.com/zh-CN/os-theme/components/input , I found many clickable were not recognized, while many others were mistakenly hinted.So I want this framework to add more clues to let such keyboard helper extensions work better.
The text was updated successfully, but these errors were encountered: