Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-number): fixed calucation issue when step is set decimal #1024

Closed

Conversation

cisolarix
Copy link
Contributor

@cisolarix cisolarix commented Aug 31, 2021

closes #1007

@vercel
Copy link

vercel bot commented Aug 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/DEpZQHDueKqFaRcvFH7ZCFvMhJMr
✅ Preview: https://naive-ui-git-fork-cisolarix-ym-input-number-flo-597e04-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #1024 (a373da3) into main (5e219eb) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1024      +/-   ##
==========================================
+ Coverage   46.93%   47.04%   +0.11%     
==========================================
  Files         511      511              
  Lines       12588    12593       +5     
  Branches     3547     3548       +1     
==========================================
+ Hits         5908     5925      +17     
+ Misses       5658     5646      -12     
  Partials     1022     1022              
Impacted Files Coverage Δ
src/input-number/src/InputNumber.tsx 59.78% <100.00%> (+7.26%) ⬆️
src/input/src/Input.tsx 46.55% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e219eb...a373da3. Read the comment docs.

@07akioni
Copy link
Collaborator

07akioni commented Sep 1, 2021

@cisolarix 看起来这个 bug 已经在其他 PR 修复了,你可以把测试用例合一下,代码应该就不用了

@cisolarix cisolarix closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

n-input-number
2 participants