Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): fix show-preview-button not working #1258

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

kev1nzh37
Copy link
Collaborator

@kev1nzh37 kev1nzh37 commented Sep 28, 2021

fix #1238

@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/3vjY5WY6565vRCn62tq6jVP3c8KY
✅ Preview: https://naive-ui-git-fork-kev1nzh37-feature-upload-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1258 (b8ba892) into main (468055b) will increase coverage by 0.01%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   50.80%   50.81%   +0.01%     
==========================================
  Files         518      518              
  Lines       12835    12850      +15     
  Branches     3650     3659       +9     
==========================================
+ Hits         6521     6530       +9     
- Misses       5210     5213       +3     
- Partials     1104     1107       +3     
Impacted Files Coverage Δ
src/tabs/src/Tabs.tsx 44.17% <0.00%> (-0.28%) ⬇️
src/upload/src/Upload.tsx 67.91% <ø> (ø)
src/upload/src/interface.ts 100.00% <ø> (ø)
src/grid/src/Grid.tsx 57.83% <64.70%> (+0.49%) ⬆️
src/upload/src/UploadFile.tsx 69.56% <66.66%> (ø)
src/button/src/Button.tsx 73.52% <71.42%> (-0.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2401fc...b8ba892. Read the comment docs.

@07akioni
Copy link
Collaborator

草,原来是这个原因

@07akioni 07akioni merged commit 3b39e25 into tusen-ai:main Sep 28, 2021
@kev1nzh37
Copy link
Collaborator Author

草,原来是这个原因
我的锅,一开始写的时候就特么写错了

@kev1nzh37 kev1nzh37 deleted the feature/upload branch October 13, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] show-preview-button props false is not working in n-upload
2 participants