Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(carousel): add dotPlacement and dotShape props #1556

Closed
wants to merge 17 commits into from

Conversation

LYErin
Copy link
Contributor

@LYErin LYErin commented Nov 10, 2021

closed #1462

@vercel
Copy link

vercel bot commented Nov 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/9rCj76LQoyWe2eKTE3Xw3KnYxdC6
✅ Preview: https://naive-ui-git-fork-lyerin-add-carousel-feat-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1556 (0c84bc6) into main (7bf0814) will decrease coverage by 0.00%.
The diff coverage is 47.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
- Coverage   64.67%   64.67%   -0.01%     
==========================================
  Files         899      899              
  Lines       17620    17636      +16     
  Branches     4174     4185      +11     
==========================================
+ Hits        11396    11406      +10     
- Misses       5437     5440       +3     
- Partials      787      790       +3     
Impacted Files Coverage Δ
src/carousel/src/styles/index.cssr.ts 100.00% <ø> (ø)
src/carousel/styles/light.ts 100.00% <ø> (ø)
src/carousel/src/Carousel.tsx 40.00% <47.82%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf0814...0c84bc6. Read the comment docs.

src/carousel/demos/enUS/dot-placement.demo.md Outdated Show resolved Hide resolved
src/carousel/demos/enUS/dot-shape.demo.md Outdated Show resolved Hide resolved
src/carousel/demos/zhCN/dot-shape.demo.md Outdated Show resolved Hide resolved
src/carousel/demos/zhCN/dot-placement.demo.md Outdated Show resolved Hide resolved
src/carousel/styles/light.ts Outdated Show resolved Hide resolved
@07akioni
Copy link
Collaborator

image

这个要弄的话做一个条能动的吧

@LYErin
Copy link
Contributor Author

LYErin commented Nov 12, 2021

image

这个要弄的话做一个条能动的吧

@07akioni
Copy link
Collaborator

07akioni commented Jan 8, 2022

在这个重构都包含了 #2061

@07akioni 07akioni closed this Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carousel enhancements - Indicator style and position
4 participants