Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): n-calendar supports RTL #4394

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jahnli
Copy link
Collaborator

@jahnli jahnli commented Jan 21, 2023

ref #97

@vercel
Copy link

vercel bot commented Jan 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
naive-ui ❌ Failed (Inspect) Jan 23, 2023 at 8:48AM (UTC)

@jahnli jahnli temporarily deployed to test January 21, 2023 11:06 — with GitHub Actions Inactive
@jahnli jahnli temporarily deployed to test January 21, 2023 11:06 — with GitHub Actions Inactive
@jahnli jahnli changed the title feat(calendar): calendar supports RTL feat(calendar): n-calendar supports RTL Jan 21, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2023

Codecov Report

Base: 62.49% // Head: 62.50% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (eea6e57) compared to base (4d51a39).
Patch coverage: 86.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4394      +/-   ##
==========================================
+ Coverage   62.49%   62.50%   +0.01%     
==========================================
  Files        1069     1071       +2     
  Lines       22420    22429       +9     
  Branches     5882     5883       +1     
==========================================
+ Hits        14011    14019       +8     
  Misses       6881     6881              
- Partials     1528     1529       +1     
Impacted Files Coverage Δ
src/calendar/src/Calendar.tsx 80.45% <60.00%> (-0.72%) ⬇️
src/calendar/src/styles/rtl.cssr.ts 100.00% <100.00%> (ø)
src/calendar/styles/index.ts 100.00% <100.00%> (ø)
src/calendar/styles/rtl.ts 100.00% <100.00%> (ø)
src/styles.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jahnli jahnli temporarily deployed to test January 23, 2023 08:47 — with GitHub Actions Inactive
@jahnli jahnli temporarily deployed to test January 23, 2023 08:47 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants