Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat time picker step #498

Merged
merged 7 commits into from
Jul 14, 2021
Merged

Feat time picker step #498

merged 7 commits into from
Jul 14, 2021

Conversation

XieZongChen
Copy link
Collaborator

rebase #36

@vercel
Copy link

vercel bot commented Jul 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/7kXtYQtgiov6XRNWiGCPNXh6Ria8
✅ Preview: https://naive-ui-git-fork-amadeus711-feat-timepickerstep-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #498 (a927682) into main (9c4997b) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   37.11%   37.07%   -0.05%     
==========================================
  Files         507      507              
  Lines       12183    12197      +14     
  Branches     3354     3359       +5     
==========================================
  Hits         4522     4522              
- Misses       6796     6810      +14     
  Partials      865      865              
Impacted Files Coverage Δ
src/time-picker/src/Panel.tsx 0.00% <0.00%> (ø)
src/time-picker/src/TimePicker.tsx 23.83% <0.00%> (-0.93%) ⬇️
src/time-picker/src/utils.ts 50.00% <0.00%> (-50.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4997b...a927682. Read the comment docs.

@07akioni
Copy link
Collaborator

这个 feature 算勉强能用了,不过:

  1. 在点击时间的时候,可能会选中一些在刻度里不存在的时间
  2. 可能会输入一些不合法的时间
    这两个都需要处理一下

@XieZongChen
Copy link
Collaborator Author

这个 feature 算勉强能用了,不过:

  1. 在点击时间的时候,可能会选中一些在刻度里不存在的时间
  2. 可能会输入一些不合法的时间
    这两个都需要处理一下

收到

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants