Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(image): Initialize rotate before switching, closes #921 #928

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

kev1nzh37
Copy link
Collaborator

#921

这里需要实现切换图像后保留旋转或缩放的效果吗?

@vercel
Copy link

vercel bot commented Aug 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/tusimple/naive-ui/ejSoZByKawzGc7x6R7zMN3wdykTW
✅ Preview: https://naive-ui-git-fork-kev1nzh37-feature-image-tusimple.vercel.app

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #928 (f819899) into main (efa6484) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
- Coverage   44.64%   44.63%   -0.01%     
==========================================
  Files         509      509              
  Lines       12459    12461       +2     
  Branches     3501     3501              
==========================================
  Hits         5562     5562              
- Misses       5896     5898       +2     
  Partials     1001     1001              
Impacted Files Coverage Δ
src/image/src/ImagePreview.tsx 24.80% <0.00%> (-0.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa6484...f819899. Read the comment docs.

@07akioni
Copy link
Collaborator

我感觉切换之后就不应该保留了

@07akioni 07akioni merged commit 4d6f28e into tusen-ai:main Aug 20, 2021
rhengles pushed a commit to arijs/naive-ui that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants