Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding SweetAlert as a service #10

Merged
merged 1 commit into from
Jun 3, 2016

Conversation

outmost
Copy link
Contributor

@outmost outmost commented May 27, 2016

Entirely based on the work by @narkissbv here:
#3

I can take no credit for the code.

  • Updated README
  • Added $q injection to prevent Angular complaints when using strict
    mode

Entirely based on the work by @narkissbv here:
tushar-borole#3

I can take no credit for the code.

- Updated README
- Added $q injection to prevent Angular complaints when using strict
mode
@outmost
Copy link
Contributor Author

outmost commented May 27, 2016

The reason for injecting $q

Error: $injector:strictdi
Explicit annotation required
sweetalert_service is not using explicit annotation and cannot be invoked in strict mode

https://docs.angularjs.org/error/$injector/strictdi?p0=sweetalert_service

@tushar-borole
Copy link
Owner

@tomsutton1984 Thank you lot.
Give me 2 days, as i want to test this pull request and am out of town,
Have happy weekend 👍

@tushar-borole tushar-borole merged commit 8172ee9 into tushar-borole:master Jun 3, 2016
@tushar-borole
Copy link
Owner

@tomsutton1984 merged, thank you for contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants