fix(core): copy initial values to the prop before creating setter/get…

…ters
tusharmath · Sep 14, 2016 · 23015bb · 23015bb
1 parent 9a589bc
commit 23015bb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/src/createWCProto.js b/src/createWCProto.js
@@ -68,6 +68,7 @@ export default (virtualDOMPatcher, component) => {
       this.__render = this.__render.bind(this)
 
       props.forEach(p => {
+        this.__props[p] = this[p]
         Object.defineProperty(this, p, {
           get: () => this.__props[p],
           set: (params) => {

diff --git a/test/test.createWCProto.js b/test/test.createWCProto.js
@@ -235,3 +235,17 @@ test('__reducer', t => {
   ])
   t.true(wc.dispatchEvent.calledWith(mockEV))
 })
+test('createdCallback():copy-initial-values', t => {
+  const mockPatcher = createMockPatcher()
+  const attachShadow = () => '@ROOT'
+  const component = createMockComponent()
+  const wc = rwc.createWCProto(mockPatcher.patcher, component)
+  wc.attachShadow = attachShadow
+  wc['A'] = 'aaa-initial-value'
+  wc['B'] = 'bbb-initial-value'
+  wc['C'] = 'ccc-initial-value'
+  wc.createdCallback()
+  t.is(wc['A'], 'aaa-initial-value')
+  t.is(wc['B'], 'bbb-initial-value')
+  t.is(wc['C'], 'ccc-initial-value')
+})