Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using spritesheets for Emojis rather than fonts #703

Closed
1 task done
koyuawsmbrtn opened this issue Jul 2, 2018 · 11 comments
Closed
1 task done

Using spritesheets for Emojis rather than fonts #703

koyuawsmbrtn opened this issue Jul 2, 2018 · 11 comments

Comments

@koyuawsmbrtn
Copy link
Contributor

This approach would be better, because Tusky would support Emojis, that aren't supported by the Android operating system. It would give users a more streamlined experience across the web version of Mastodon and their various Android devices running Tusky.


  • Tusky Version: 2.0+

  • Android Version: any

  • Android Device: any

  • Mastodon instance (if applicable): any

  • I searched or browsed the repo’s other issues to ensure this is not a duplicate.

@charlag
Copy link
Collaborator

charlag commented Jul 2, 2018

I may be mistaken but I think the approach we use now should allow you to see emojis which are not supported by your system. Could you specify your Android version pls?

@connyduck
Copy link
Collaborator

Yes our approach should definitely also replace emojis not supported by the platform.
Could you post a link to a status that does nor work for you & a screenshot of it please?
cc @C1710

@C1710
Copy link
Contributor

C1710 commented Jul 2, 2018

Well, at least it supports all emojis that are included in the latest Emoji 11 standard as well as some custom ZWJ-sequences (these sequences are only available for Blobmoji).
Additional characters have to be included in the fonts, but as I mentioned both Twemoji and Blobmoji already support all official emoji characters (maybe with the exception of some flags and some symbols which aren't rendered as emojis).

@C1710
Copy link
Contributor

C1710 commented Jul 2, 2018

Anyhow I got some issues with ZWJ sequences not working on devices with KitKat. But this shouldn't affect a larger user group (and especially not the Tusky users, since the support for Lollipop and lower is currently disabled).

@C1710
Copy link
Contributor

C1710 commented Jul 2, 2018

Here's an example of all the Emoji 11 emojis:
https://mastodon.xyz/@C1710/100264999957588974
If any of them are not visible, it's just another bug

@koyuawsmbrtn
Copy link
Contributor Author

koyuawsmbrtn commented Jul 2, 2018

This is how it looks like on Android 6.0 with Twemoji enabled (cc @C1710):

image

@C1710
Copy link
Contributor

C1710 commented Jul 2, 2018

Well, that's definetly not the intended behavior... Which emoji pack do you use?

@koyuawsmbrtn
Copy link
Contributor Author

Twemoji

@C1710
Copy link
Contributor

C1710 commented Jul 2, 2018

So it's another bug with the two EmojiCompat fonts...
My next assumption would be that the script that generates the fonts isn't made for more emojis than the ones available in Emoji 5.0, but that's just another wild guess.
I'll have to check it again in the next few days, but i think I'll need some sleep now.
But this really gets frustrating....
(It's actually not (directly) the fault of the library but rather of the script that creates the EmojiCompat fonts, since the fonts themselves are definetly compatible with Android 4.4+)

@C1710
Copy link
Contributor

C1710 commented Jul 4, 2018

Just for the records: The problem was, that older Android versions seem to have trouble with this issue.
So in the end there was no issue with the fonts but with the Android OS not accepting the correct version.

@C1710
Copy link
Contributor

C1710 commented Jul 5, 2018

@connyduck I guess you can close this issue 😅 (Fixed in Pullrequest #5 to tuskyapp.github.io)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants