Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When writing a reply, text disappears if app switches from portait to landscape #45

Closed
xuv opened this issue Apr 2, 2017 · 6 comments
Closed
Labels

Comments

@xuv
Copy link

xuv commented Apr 2, 2017

Tusky v 1.0.3
Steps to reproduce:

  • Click reply to a toot and start writing after the usernames
  • Rotate the phone from portrait to landscape

Result:

  • The text entered disappeared. Username still there.

Expected result:

  • The reply content should be the same before the phone rotation.
@Aldarone
Copy link

Aldarone commented Apr 3, 2017

I'm on Tusky 1.1.0 and the app crash when I do this.

@raphaelbastide
Copy link

raphaelbastide commented Apr 3, 2017

I confirm @xuv’s bug exists on my Android phone.

@alerque
Copy link
Contributor

alerque commented Apr 6, 2017

I've seen something similar but maybe not the same bug while switching between apps. A toot I was writing has gone missing several times but I haven't been able to pin down the circumstances. Given that my device is orientation locked it is some other app redraw event.

@Vavassor
Copy link
Collaborator

Vavassor commented Apr 6, 2017

I know the crash that @Aldarone has is already fixed, so that will be fixed in 1.1.1.

The EditText (the main text box for the compose page) is actually recreated every time the activity is created. But the text and selection state is saved in a Bundle called savedInstanceState and restored manually to the newly-created EditText. So, either the saving or restoring side of that process isn't happening in some case.

@Vavassor Vavassor added the bug label Apr 6, 2017
@xuv
Copy link
Author

xuv commented Apr 7, 2017

@Vavassor If that helps, the text restoration is happening as expected when calling a new toot. It's just when responding that it bugs.

@Vavassor
Copy link
Collaborator

Vavassor commented May 5, 2017

The compose page is not longer recreated when reorienting so there's no way for this bug to occur now.

@Vavassor Vavassor closed this as completed May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants