Skip to content

Commit

Permalink
fix dialog layout for Firefox, fixes #764
Browse files Browse the repository at this point in the history
  • Loading branch information
armhub committed Nov 15, 2018
1 parent 97fbea1 commit d73d7c8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/gui/base/Dialog.js
Expand Up @@ -67,7 +67,8 @@ export class Dialog {
paddingTop: requiresStatusBarHack() ? '20px' : 'env(safe-area-inset-top)'
}
}, // controls vertical alignment
m(".flex.justify-center.align-self-stretch.rel"
// we need overflow-hidden (actually resulting in min-height: 0 instead of auto) here because otherwise the content of the dialog may make this wrapper grow bigger outside the window on some browsers, e.g. upgrade reminder on Firefox mobile
m(".flex.justify-center.align-self-stretch.rel.overflow-hidden"
+ (dialogType === DialogType.EditLarge ? ".flex-grow" : ".transition-margin"), { // controls horizontal alignment
style: {
'margin-top': mobileMargin,
Expand Down

0 comments on commit d73d7c8

Please sign in to comment.